feat: Improve validation in MethodToolCallbackProvider #2964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that validation errors are caught early during object construction rather than later when methods are called, providing better error feedback. - Add validation for tool-annotated methods during construction - Validate duplicate tool names in constructor instead of only at getToolCallbacks() time - Add comprehensive test suite for MethodToolCallbackProvider Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
ThomasVitale
reviewed
May 1, 2025
| .toList(); | ||
|
|
||
| if (toolMethods.isEmpty()) { | ||
| throw new IllegalStateException("No @Tool annotated methods found in " + toolObject); |
There was a problem hiding this comment.
Consider extending this message to include "Did you mean to pass a ToolCallback or ToolCallbackProvider? If so, you have to use .toolCallbacks() instead of .tool()".
It could also be a warn log message.
There was a problem hiding this comment.
I think we are seeing that this is a pretty critical fix, the app won't work as expected so I think an exception rather than a warn message is appropriate. agree wrt to the log message.
There was a problem hiding this comment.
Agree. Also they could mean to call defaultToolCallbacks or defaultTool.
ThomasVitale
reviewed
May 1, 2025
| validateToolCallbacks(getToolCallbacks()); | ||
| } | ||
|
|
||
| private void assertToolAnnotatedMethodsPresent(List<Object> toolObjects) { |
|
merged in 6c52c99 kept the exception, can change if needed. let's see how this plays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that validation errors are caught early during object construction rather than later when methods are called, providing better error feedback.